Fix overflows of Navigator
#35310
Closed
Fix overflows of Navigator
#35310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use size prop for improved content alignment
|
Size Change: -220 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
15 tasks
stokesman
added
the
General Interface
|
Thank you @stokesman for having a go at this. I've already been working on a solution for this issue last week, and I've just opened #35317 with a solution that still uses the I would say that this PR can be closed in favour of #35317. For the changes applied to the Preferences Modal, you may want to open a separate PR containing only these changes after #35214 and #35317 (or any alternative) are merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion for part of #34907, specifically:
Here the issue is solved outside the component so It could be considered a bit of a punt.
I've thrown in some extra changes to improve the Post Editor’s preferences use of
Navigator. The structure is tweaked and props adjusted to create better alignment. I may include before/after screenshots for that but later…How has this been tested?
Manually in Site and Post Editor. I didn't actually test the
Navigatorstorybook story yet.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).