[Mobile] - Font size support for the blocks: Button, Preformatted and Heading levels. #35314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Heading sublevels
geriux
added
[Status] In Progress
|
Size Change: -1 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
2 tasks
enejb
reviewed
Oct 7, 2021
enejb
reviewed
Oct 7, 2021
|
I ran into this issue while testing out the Button font sizes. The whole editor crashed.
|
|
Test case 2 - Worked as expected |
|
Overall nice work. |
Nice catch! I'll work on a fix for that |
added 3 commits
October 11, 2021 09:40
# Conflicts: # packages/block-library/src/button/edit.native.js
…t size units in the PlainText component
This is also fixed now, can you check it again? Thanks! |
|
I tested this PR and it worked really well. One thing that I notice is that you are currently not able to set different headings (for example h1, h2) to be the same size. In the browser, they are set the same. See
I think this can probably be addressed in a different PR. |
Nice catch! I'll create an issue to handle this in another PR. Thanks for the review! |
5 tasks
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues to add support for font size to other pending blocks:
Button,Preformatted,Codeas well as extend support for the levels (h1, h2, h3, etc.) of theHeadingblock.theme.jsonsee this example.getPxFromCssUnit.NOTE: On iOS, there's a current issue where changing the font size is not reflected visually for the following blocks:
Heading,VerseandPreformatted. This is currently being investigated and hopefully addressed in another PR.How has this been tested?
Test case 1 - Button block
ButtonsblockTest case 2 - Preformatted (Font size)
PreformattedblockTest case 3 - Preformatted (Text and background colors)
PreformattedblockTest case 4 - Heading levels
HeadingblockScreenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).