Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site editor block placeholder styling #35513

Merged
merged 8 commits into from
Oct 14, 2021
Merged

Update site editor block placeholder styling #35513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33c960c
Update styling
jameskoster Oct 11, 2021
0b7a014
Post author weight, fix imports
jameskoster Oct 11, 2021
32e3f01
increase featured image height
jameskoster Oct 11, 2021
a76a286
Revert featured image changes
jameskoster Oct 11, 2021
d3baa94
Merge branch 'trunk' into update/theme-block-placeholder-styling
jameskoster Oct 12, 2021
9c0b90e
Merge branch 'trunk' into update/theme-block-placeholder-styling
jameskoster Oct 12, 2021
dc8a095
Formatting
jameskoster Oct 12, 2021
ea8173f
Remove editor styles for Post Author
jameskoster Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/block-library/src/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
@import "./page-list/editor.scss";
@import "./paragraph/editor.scss";
@import "./post-excerpt/editor.scss";
@import "./post-author/editor.scss";
@import "./pullquote/editor.scss";
@import "./rss/editor.scss";
@import "./search/editor.scss";
Expand All @@ -39,13 +38,11 @@
@import "./template-part/editor.scss";
@import "./text-columns/editor.scss";
@import "./video/editor.scss";
@import "./query-title/editor.scss";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we can remove all of these single-purpose stylesheets.

@import "./post-template/editor.scss";
@import "./query/editor.scss";
@import "./query-pagination/editor.scss";
@import "./query-pagination-numbers/editor.scss";
@import "./post-featured-image/editor.scss";
@import "./term-description/editor.scss";

:root .editor-styles-wrapper {
@include background-colors-deprecated();
Expand Down
35 changes: 0 additions & 35 deletions packages/block-library/src/post-author/editor.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/block-library/src/post-author/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
}

&__name {
font-weight: bold;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

margin: 0;
}
}
6 changes: 1 addition & 5 deletions packages/block-library/src/post-excerpt/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,7 @@ export default function PostExcerptEditor( {
return document.body.textContent || document.body.innerText || '';
}, [ renderedExcerpt ] );
if ( ! postType || ! postId ) {
return (
<div { ...blockProps }>
<Warning>{ __( 'Post Excerpt' ) }</Warning>
</div>
);
return <div { ...blockProps }>{ __( 'Post Excerpt' ) }</div>;
}
if ( isProtected && ! userCanEdit ) {
return (
Expand Down
4 changes: 0 additions & 4 deletions packages/block-library/src/query-title/editor.scss
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/block-library/src/term-description/editor.scss
View file
Open in desktop

This file was deleted.