Unify theme block placeholder content #35517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Size Change: -18 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Nice one, took it for a spin and seeing this: I'm testing inside the post editor even though you said site editor, because I'm a rebel. (I'll also come back to the site editor). Here's some testing content: I'm noting that this PR is only for the verbiage, which is good to unify. Two thoughts, though:
|
Good spot. I think I lean towards titlecase. It doesn't feel quite right for the Post Content block, but feels more appropriate in general. Re post terms, ideally the output should be contextual, IE "Post Categories" instead of "Post Terms". Unfortunately this is beyond my skill to implement since these are block variations. |
jasmussen
approved these changes
Oct 12, 2021
7 tasks
|
One note. It probably would be better to use the i18n function with the context so there is only one translation used. For the block title it is In other places it's handled with |
|
Oh yeah that sounds better, unfortunately I'm not sure how to do that 😞 |
|
The following should do the trick: - <p>{ __( 'Post Content' ) }</p>
+ <p>{ _x( 'Post Content', 'block title' ) }</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35501.
Unifies the content of site editor block placeholder states by simply echoing the block name.
To test:
Unfortunately Post Categories and Post Tags blocks are variations of the Post Terms block, so I don't think we can be more explicit on the canvas.