Storybook: Add RTL switcher to toolbar #35711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
talldan
approved these changes
Oct 18, 2021
talldan
added
[Type] Enhancement
1 task
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35642
Description
Adds a toolbar item in the Storybook to switch between LTR and RTL modes.
This will make it much easier to check for RTL support when styling our components, especially for those written in Emotion where RTL styles are not auto-generated.
RTL simulation is achieved by:
dirattribute of the root element (<html dir="rtl">).html[dir="ltr"]andhtml[dir="rtl"]. (This will invalidate any CSS variables declared on:root, but basically the only things declared there are wp-admin-theme colors, which we can import separately.)@wordpress/i18nisRTL()function, which is used in both React and Emotion conditionals.How has this been tested?
npm run storybook:dev✅ Smoke test that the default LTR versions of the stories look unchanged.
✅ Check that both static CSS components (e.g.
CheckboxControl) and Emotion components (e.g.AnglePickerControl) look the same in RTL-enabled Storybook and RTL-enabled wp-admin (npm run wp-env startand set site lang to Hebrew).Screenshots
Types of changes
New feature, Storybook only.
Checklist:
*.native.jsfiles for terms that need renaming or removal).