-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for the mark yellow background and markup persistence issue #35813
Conversation
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
@@ -548,4 +549,51 @@ describe( 'RichText', () => { | |||
// Expect: <strong>1</strong>-<em>2</em> | |||
expect( await getEditedPostContent() ).toMatchSnapshot(); | |||
} ); | |||
|
|||
// Regression test for https://github.com/WordPress/gutenberg/pull/35516. | |||
it.only( 'should properly handle pre-<mark> `text-color` markup', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably come up with a better description here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! I've introduced a new description in the PR below.
).map( ( el ) => ( { | ||
tag: el.localName, | ||
style: el.getAttribute( 'style' ), | ||
class: el.getAttribute( 'class' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove this attribute, as it seems we won't be checking against it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I've removed in my PR (see below)
Due to access level on the repo, I needed to submit through my own fork, so I have a new PR with the rest of the regression test here: #35847 |
Related to: #35516