-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Details: Update regex to include og:description
#35875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The og:description
regex and associated test data are ready to go. Well done @Mamaduka 🥇 I'm approving this PR for the og:description
enhancement.
But I'd suggest reverting the whitespace removal changes to maintain an og:description
enhancement atomic commit. Why? Code churn. The whitespace changes do not impact test results, code quality, or the goals of the og:description
enhancement.
Thanks @Mamaduka 🙌
If I'm reading this right, it seems like whether |
Is there any existing pattern in place for preferring IMHO it would seem reasonable to prefer OG and fallback to other options. |
@TimothyBJacobs is right. Value is picked based on what comes first in the document. It is similar to how we get image URLs. I don't have a strong preference here. |
@hellofromtonya, thanks for the review. I was about to revert trailing whitespace changes, but it looks like settings is set in the project on the Line 13 in d209b27
Reverting changes will mean that we'll get similar unwanted changes tracked in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mamaduka If this matches the existing pattern for returning whatever comes first in the document then I'm happy to roll with that.
Nice work here. I'll let others feedback on whitespace as I also have this question in another PR.
Thanks, everyone, for the reviews. I'm going to merge this since trailing whitespace changes matches the editor configuration. |
Description
PR updates regex to include
og:description
when looking for valid site descriptions.Fixes #33754.
P.S. Sorry about whitespace changes. Let me know if you want me to revert it.
How has this been tested?
Unit tests are passing.
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).