Remove "experimental" from URL details REST controller and promote to v1 namespace
#35915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
TimothyBJacobs
approved these changes
Oct 25, 2021
|
@kevin940726 Any chance you could give this the once over from a manual testing POV? |
|
Works for me on local testing but not on gutenberg.run. I'm not sure If it's expected? |
I tried
Not seen that before. I tried building another PR branch on the same platform I saw the same error. Therefore I assume it's due to Happy to 👍 ? |
kevin940726
approved these changes
Oct 27, 2021
getdave
force-pushed
the
update/url-details-namespace
branch
from
20cc5fb to
aff754d
Compare
|
Let's get these e2e tests passing. Rebase should do it 🤞 I'll merge once ✅ |
|
@hellofromtonya Good to go now. Trac ticket next? |
|
@getdave Cool 🎉 Yes, Trac ticket and PR => next steps. I'll take care of both on Monday and then get URL Details and Previewer merged into Core before 5.9 feature freeze (Nov 9th). |
andrewserong
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #35756 (comment) this PR removes the experimental status from the URL Details endpoint and promotes it to a first class API endpoint under the
wp-block-editor/v1namespace.This PR also updates tests and client side code to utilise the new namespace.
Also includes some fixes to whitespace which were applied automatically. I guess I can get rid of those if it's annoying.
How has this been tested?
Firstly check all the existing PHP unit tests are passing on this PR for the endpoint.
Next check the client side "rich preview" functionality is still working as expected:
wordpress.orgbrings up a nice rich preview).url-details.wp-block-editor/v1/url-detailsendpoint.Screenshots
Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
*.native.jsfiles for terms that need renaming or removal).