Post Content: Fix float clearing on entry content #35958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
commented
Oct 26, 2021
| // Required to ensure that subsequent blocks clear floats inside entry content. | ||
| .wp-block-post-content { | ||
| overflow: hidden; | ||
| } |
There was a problem hiding this comment.
If there's an issue with using hidden here, an alternate solution would be to do something like .wp-block-post-content + * { clear:both }. The 'hidden approach seemed a little more predictable though.
There was a problem hiding this comment.
What about overflow:auto? I prefer that as its less likely to cut off things by mistake...
There was a problem hiding this comment.
Yeah, that's probably safer. Updated in f29e0c4.
|
Size Change: +106 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
This change had some unintended side effects. Any content that breaks outside of the boundaries of the post content block, whether intentionally or otherwise, are now cropped and a scrollbar appears. In this example I'm testing a navigation submenu which painly gets cropped:
Overflow is a bit of a risky property to change, so I would honestly suggest this be added to the theme instead of the block editor itself. I can think of a bunch of creative layouts, especially with negative margins in the future, where this will cause breakage. |
|
Thanks, I figured we missed something. 😅 @jasmussen do you think |
|
Potentially! Feels worth a shot. And I do think it's okay to try and fix here, but mostly we should avoid touching overflow, in my experience that always comes back to bite. |
kjellr
added a commit
that referenced
this pull request
Oct 27, 2021
andrewserong
added
[Block] Post Content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the last item in post content is a floated element, items below post content will incorrectly flow in next to it.
To test:
clear:both;, and don't have this issue. Twenty Twenty Two's page templates work for testing.)Screenshots:
Related: WordPress/twentytwentytwo#44