Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates publish-to-s3 plugin to 0.7.0 for react-native-bridge & react-native-aztec Android and publishes '-sources.jar' #36034

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Oct 28, 2021

Description

This PR updates publish-to-s3 Gradle plugin to 0.7.0 for react-native-bridge & react-native-aztec Android libraries and uses the newly introduced androidSourcesJar task to upload the -sources.jar file so it can be used by developers to access the source code from their IDEs. More details can be found in: Automattic/publish-to-s3-gradle-plugin#29

As of 0.7.0 version of the publish-to-s3 plugin, the publishToS3Plugin extension is no longer necessary, so as part of this update, the extension is removed from each project.

aztecVersion is also updated from v1.4.0 to v1.5.0 which brings the exact same changes to AztecEditor-Android: wordpress-mobile/AztecEditor-Android#942

Note that since there is no rush to get this changes in, there is no gutenberg-mobile PR for this PR.

How has this been tested?

The version upgrade for the plugin has been tested in wordpress-mobile/WordPress-Android#15492 and applied to several other libraries.

wordpress-mobile/gutenberg-mobile#4177 is used to verify the publishing still works as expected.

wordpress-mobile/WordPress-Android#15506 is used to test the aztecVersion change as well as to verify that the source files are available as part of this change.

Types of changes

Gradle plugin version change for react-native-bridge & react-native-aztec Android projects.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@oguzkocer oguzkocer added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 28, 2021
@oguzkocer oguzkocer requested a review from mchowning October 28, 2021 10:52
@oguzkocer oguzkocer marked this pull request as draft October 28, 2021 10:58
@oguzkocer oguzkocer force-pushed the update-publish-to-s3-plugin-to-0.7.0 branch from e70e73c to d10a489 Compare October 28, 2021 11:11
@oguzkocer
Copy link
Contributor Author

@mchowning I missed something minor when I first opened the PR and pushed another commit to fix it. That made me feel a bit skeptical about not opening a PR for gb-mobile and possibly WPAndroid for testing. I'll do those and mark this as ready for review. Sorry about that!

@oguzkocer
Copy link
Contributor Author

@mchowning I've ran the necessary tests, updated the PR description and marked the PR as ready for review again. Sorry for not covering everything from the start.

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great for me! Having the source available with the artifact is soo nice! Thanks @oguzkocer ! 🙇

As long as there are no changes to WPAndroid or gb-mobile that need to go along with this, the easiest thing would be to just merge this PR and not worry about those repos. These changes will get brought in the next time we incorporate the latest Gutenberg code (which happens multiple times every week). If there are related changes (I'm looking a bit suspiciously at the aztecVersion in WPAndroid, although I "feel" like that shouldn't actually cause any problems) we'll just need to make sure we merge to WPAndroid's after_#.## branch instead of develop.

@oguzkocer
Copy link
Contributor Author

Thanks @mchowning! The aztecVersion update is the only thing that needs to change in WPAndroid, but it actually doesn't necessarily need to happen as soon as the gb-mobile update happens. I'll create the PR against the after_#.## branch for this change.

@oguzkocer oguzkocer merged commit 19e6f92 into trunk Oct 29, 2021
@oguzkocer oguzkocer deleted the update-publish-to-s3-plugin-to-0.7.0 branch October 29, 2021 18:03
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants