Site Editor: Enable the "Save" keyboard shortcut #36138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[a11y] Keyboard & Focus
[Feature] Site Editor
|
Size Change: -156 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
-Not a code review. -Just to confirm, this does not solve the display of the popup with the list of short cuts, correct? Once that is solved (there is a separate issue), the term 'Save site editor changes.' will be exposed to users. That is my only reservation, because I think it will only be referred to as "the editor" not site editor? The phrase in the block and widget editors is 'Save your changes.'. Perhaps the same description should be used. |
That's correct. Do we have a separate issue for it? Can add that enhancement as well.
Thanks for pointing this out. I wasn't sure about the wording here, but your suggestion makes total sense. I'm going to update the text. |
|
Found the tracking issue for shortcuts modal - #21245. Thanks again for mentioning this, @carolinan. |
aristath
approved these changes
Nov 2, 2021
|
Tested and confirmed it works as expected. |
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds the global "Save" shortcut to the site editor.
The shortcut opens the saving process rather than saving everything. It matches the "Save" button behavior.
Fixes #29642.
How has this been tested?
Screenshots
CleanShot.2021-11-02.at.14.30.25.mp4
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).