Update Pattern block category and add documentation #36144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
added
[Type] Developer Documentation
carolinan
reviewed
Nov 2, 2021
carolinan
reviewed
Nov 2, 2021
Co-authored-by: Carolina Nymark <[email protected]>
|
Maybe add a link to the internationalization guidelines? |
carolinan
reviewed
Nov 17, 2021
carolinan
reviewed
Nov 17, 2021
carolinan
added
the
Backport to WP 6.7 Beta/RC
|
Added a few more comments. -I believe the change to the block category should also be backported to core? |
Co-authored-by: Carolina Nymark <[email protected]>
Co-authored-by: Carolina Nymark <[email protected]>
ntsekouras
reviewed
Nov 26, 2021
| '<a href="' . esc_url( __( 'https://wordpress.org', 'myblocktheme' ) ) . '" rel="nofollow">WordPress</a>' | ||
| ) . '</p> | ||
| <!-- /wp:paragraph -->', | ||
| 'inserter' => false |
There was a problem hiding this comment.
Should we highlight this flag (inserter=>false) that hides such patterns from the list of displayed patterns in inserter/explorer. etc...?
There was a problem hiding this comment.
Yeah that would be super helpful
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Update pattern category and add documentation. * Fix typo Co-authored-by: Carolina Nymark <[email protected]> * Add link to i18n docs. * Update docs/how-to-guides/themes/block-theme-overview.md Co-authored-by: Carolina Nymark <[email protected]> * Update docs/how-to-guides/themes/block-theme-overview.md Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: Ben Dwyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some documentation to the Block Theme Overview about the pattern block and how it can be used.
It also updates the block's category to
theme, since block themes will primarily use this block inside their templates.Types of changes
Documentation
Checklist:
*.native.jsfiles for terms that need renaming or removal).