Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Disable automatically managed signing for RN editor Xcode project. #36181

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Nov 3, 2021

Description

Due to changes in how certificates and provisioning profiles are now distributed, Xcode should not try to automatically manage signing for the React Native Editor project.

Related Gutenberg Mobile PR:

How these changes were applied automatically by Xcode

  1. For the GutenbergDemo target, "Automatically manage signing" was unchecked
  2. The Provisioning Profile "Gutenberg Development" was selected

How has this been tested?

Build the app using the new Gutenberg Development profile:

  1. Load the project in Xcode: xed packages/react-native-editor/ios
  2. Build and run in Simulator or a physical device

Types of changes

Non user-facing tooling update.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@twstokes twstokes added the [Type] Build Tooling Issues or PRs related to build tooling label Nov 3, 2021
@twstokes twstokes self-assigned this Nov 3, 2021
@twstokes twstokes added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 3, 2021
@twstokes twstokes marked this pull request as ready for review November 3, 2021 16:14
@twstokes twstokes requested a review from jd-alexander November 3, 2021 16:19
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @twstokes 💯

I verified that in GutenbergDemo Signing & Capabilities:

  1. "Automatically manage signing" was unchecked
  2. The Provisioning Profile of "Gutenberg Development" was selected.

The diff correlates with the settings above and the GutenbergDemo app ran as expected on an iOS Simulator. LGTM 🚢

@twstokes twstokes merged commit d476ab4 into trunk Nov 4, 2021
@twstokes twstokes deleted the rnmobile/fix/ios-editor-signing branch November 4, 2021 14:43
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants