Respect fields param for global styles REST API requests. #36206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Core REST API Task
|
Fixes originally from #36076 |
youknowriad
reviewed
Nov 4, 2021
| $data['id'] = $post->ID; | ||
| } | ||
|
|
||
| if ( rest_is_field_included( 'title', $fields ) ) { |
There was a problem hiding this comment.
Should we include both raw and rendered here as well?
There was a problem hiding this comment.
That is what is happening in the line below 😄
| $data['title']['raw'] = $post->post_title; | ||
| } | ||
| if ( rest_is_field_included( 'title.rendered', $fields ) ) { | ||
| add_filter( 'protected_title_format', array( $this, 'protected_title_format' ) ); |
There was a problem hiding this comment.
protected style variations is not something that is meaningful for the global styles IMO, so I'd rather remove all these "protected" handling.
There was a problem hiding this comment.
This is how core handles protected titles. We can't do much about it.
There was a problem hiding this comment.
Global styles posts won't be password protected, so I'm not sure we need to handle it.
There was a problem hiding this comment.
Better safe than sorry?
TimothyBJacobs
approved these changes
Nov 8, 2021
spacedmonkey
added
the
Backport to WP 6.7 Beta/RC
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Respect fields param for REST API requests. * Fix lint
andrewserong
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Respect fields param for REST API requests. * Fix lint
|
Cherry picked into the Gutenberg 11.9 release in: b147195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The global styles endpoint, does not respect fields param passed a query string.
This fix, addresses that issue.
This PR also fixes protected titles.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).