Make saveEditedEntityRecord use the entity key when available #36212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
adamziel
changed the title
Merged
youknowriad
reviewed
Nov 4, 2021
| @@ -644,12 +644,19 @@ export const saveEditedEntityRecord = ( | |||
| if ( ! select.hasEditsForEntityRecord( kind, name, recordId ) ) { | |||
| return; | |||
| } | |||
| const entities = await dispatch( getKindEntities( kind ) ); | |||
There was a problem hiding this comment.
something feels weird here. should this be select or dispatch?
There was a problem hiding this comment.
@youknowriad I just copied this over from saveEntityRecord. getKindEntities is an action, probably because it calls entities = await kindConfig.loadEntities(); later on. I wonder if it could be a selector with a resolver instead? But that's something for another PR.
There was a problem hiding this comment.
gutenberg/packages/core-data/src/actions.js
Lines 383 to 395 in 88d2956
There was a problem hiding this comment.
Indeed I guess my old self is to blame for this confusion :P
There was a problem hiding this comment.
This code should actually be like:
const entities = await resolveSelect.getEntitiesByKind( kind );The getEntitiesByKind selector already exists, but it doesn't have a resolver attached. That needs to be fixed to make resolveSelect work. Now, we need to manually dispatch the getKindEntities action that fetches and populates the state read by getEntitiesByKind.
andrewserong
added
the
[Type] Bug
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in
saveEditedEntityRecordwhich right now assumes that entity key is calledid. After the fix, it uses theentity.keyjust likesaveEntityRecord.How has this been tested?
Confirm all the tests pass.