Disable ability to edit menus via Appearance -> Navigation Menus for non-FSE themes
#36257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-vlasenko
commented
Nov 5, 2021
| @@ -418,7 +418,8 @@ function gutenberg_register_navigation_post_type() { | |||
| 'description' => __( 'Navigation menus.', 'gutenberg' ), | |||
| 'public' => false, | |||
| 'has_archive' => false, | |||
| 'show_ui' => true, | |||
There was a problem hiding this comment.
I’m not sure whether we should disable wp_navigation definition entirely or just the show_ui flag. My PR only disables the show_ui flag.
There was a problem hiding this comment.
When in doubt, do the safe thing. show_ui it is for now.
anton-vlasenko
added
[Block] Navigation
adamziel
approved these changes
Nov 5, 2021
anton-vlasenko
deleted the
fix/hide-navigation-menus-ui-for-non-fse-themes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We must not allow to manage
wp_navigationtype posts when the current theme doesn's support FSE.Fixes #36258
How has this been tested?
Twenty Twenty-One.Appearancemenu. There must be noNavigation Menuitems.TT1 blocks).Appearancemenu. There must beNavigation Menumenu item.Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).