Writing Flow Multi-select: ensure post title content editable after multi-select #36843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulti-select. Adding tests.
ramonjd
added
[Type] Bug
|
Size Change: +516 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
apeatling
approved these changes
Nov 25, 2021
ramonjd
deleted the
try/fix-post-title-content-editable-after-multiselect
branch
ntsekouras
reviewed
Nov 26, 2021
| Array.from( | ||
| container.querySelectorAll( | ||
| // Exclude the Post Title from multi-select disable. | ||
| '.rich-text:not( .editor-post-title__input )' |
There was a problem hiding this comment.
@ellatrix could we solve this issue without adding the selector from editor package to block-editor? Any thoughts?
There was a problem hiding this comment.
Yes. :) We should make the post title a block and lots of issues will be resolved. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can you, after multi-selecting blocks in the post editor, edit your formerly-editable post title?
I can't. I've tried block and non-block themes, including TwentyNineteen, TwentyTwentyTwo and TT1.
This PR tries to fix that by excluding the post title rich text element from the collection of elements whose content may not be edited during a multi-select.
This is my first look into this area, so I'd welcome advice as to whether there's a better way.
Testing
Create a new post. Give it a title, e.g.,
' Let Your Love Flow, by the Bellamy Brothers'Now include a few blocks, maybe a couple of paragraphs. Write what you will. My topic was "miscreants".
Select two or more blocks by dragging your mouse over them. Also try using the keyboard via SHIFT + Arrow keys. You'll know they're selected if they all have a blue border.
Now click elsewhere on the document.
You should still be able to update your site title, where you could not before.
Run
npm run test-unit packages/block-editor/src/components/writing-flow/test/use-multi-selection.jsand leave some room in your life for old style country music.Checklist:
*.native.jsfiles for terms that need renaming or removal).