-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme.json version #36917
Update theme.json version #36917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -1077,7 +1077,7 @@ | |||
"version": { | |||
"description": "Version of theme.json to use.\nSince 5.8.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, was looking and this and wondered if there a way to say:
- this property
version
is present since 5.8 - its value was changed to
2
in 5.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think trying to add notes to that level of detail would be too difficult to keep updated. We could also just remove those version notes completely since we have tagged versioning now. However, it's still kind of nice when using trunk to see when things were added without having to open all the previous versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think that we need to update the "Version of theme.json to use.\nSince 5.8.",
to be "Version of theme.json to use.\nSince 5.9.",
correct? Because v2 of theme.json
is not available until WordPress 5.9 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think I see my confusion. We're describing the property introductory version. Super confusing!
We could also just remove those version notes completely since we have tagged versioning now.
I would vote for this based on my example of confusion. 🤦
Cherry-picked for 5.9.1. |
Description
With #36155 the schema version needs to be updated to 2.
It looks like the v2 properties were updated without updating the version, so this is the only change needed.
Version 1 is not allowed because the new properties are not available in version 1. This will help folks see which properties need updating when switching to version 2.
How has this been tested?
See that version 2 theme.json files work with the schema
Types of changes
Fix
Checklist:
*.native.js
files for terms that need renaming or removal).