[Edit Post]: Remove EditPostSettings context provider #36949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
youknowriad
reviewed
Nov 29, 2021
| @@ -127,6 +126,9 @@ function Editor( { | |||
| // This is marked as experimental to give time for the quick inserter to mature. | |||
| __experimentalSetIsInserterOpened: setIsInserterOpened, | |||
| keepCaretInsideBlock, | |||
| // Keep a reference of the `allowedBlockTypes` from the server to handle use cases | |||
| // where we need to differentiate if a block is disabled by the user or some plugin. | |||
| defaultAllowedBlockTypes: settings.allowedBlockTypes, | |||
There was a problem hiding this comment.
This is not needed right? Or am I missing something?
There was a problem hiding this comment.
This seems to be needed because below we override the allowedBlockTypes in the editor settings taking into account the hiddenBlockTypes. This results in not being able to show a full list of blocks that are allowed in terms of editor settings but were disabled by the user (BlockManager case).
There was a problem hiding this comment.
Was this a bug in trunk, I fail to see how this related to the removal of the context provider.
There was a problem hiding this comment.
It's not a bug, but when BlockManager was introduced the allowedBlockTypes was used in combination with the new hiddenBlockTypes setting. The alternative would be to leave allowedBlockTypes intact, and take into account hiddenBlockTypes in every place we would need - mainly in Inserter logic. This initial decision still makes sense to me as the BlockManager is more of an 'edge' case in my mind and the inserter logic runs very often.
Makes sense?
There was a problem hiding this comment.
yes, sorry I got confused :)
|
Size Change: -26 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By working on post-editor for another issue, I noticed that we had a context provider that was used only to differentiate if a block is disabled by the user or some plugin.
This PR removes this provider by adding the original value in editor settings and also refactors a bit the
BlockManagerCategoryto stop using `withSelect, withDispatch, etc...