Fix wordbreak for URLs #36993
Merged
Fix wordbreak for URLs #36993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
This makes me happy! On my review list for today 🙇 |
|
Size Change: +32 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
We also have PR with an alternative fix - #36980. |
jasmussen
force-pushed
the
fix/url-scrollbar
branch
from
d311789 to
fb0de30
Compare
|
I don't have a strong opinion on which fix is worth landing, but for some context on the additional properties I added, CSS tricks has a great rundown. |
|
Thanks, @jasmussen. I also don't have a strong opinion on this. |
ntsekouras
reviewed
Nov 30, 2021
ntsekouras
approved these changes
Nov 30, 2021
7 tasks
jasmussen
force-pushed
the
fix/url-scrollbar
branch
from
09a6aa2 to
ecddfda
Compare
|
I can't quite figure out why the PHP unit tests keep failing. |
|
Ok, here's a "moderately warm" opinion 😅: given that users will still be able to see and edit the full URL, I'd prefer truncating the string as the other PR does, because the popover will be generally shorter. Here's an example of the same URL using this PR (left) and the other one (right).
Also, notice that this PR does something weird with the title. |
Please can I sound a slight warning bell here that I've had lots of feedback from users in the past that they often need to be able to see the full URL. If we do go down this route for UX/UI reasons, please can we include a method for users to be able to see the full URL? Perhaps an expose on hover or a tooltip or something? 🙏 🙏 🙏 🙏 🙏 |
getdave
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Thank you for picking this one up 🙇
I have also tested and I like this PR because it involves no truncation of strings. The property used has good x-browser support as well.
As mentioned in #36993 (comment) I recommend we don't truncate unless we provide a means by which the user can still access the full URL.
+1 this makes sense. We could also increase the number of the truncated characters so we showed two lines at most instead of always one. |
Oh.. this is valid. We should apply the css rule in the url only. |
|
Here is the PR where I added word wrapping instead of clipping originally in response to the user feedback |
|
Thanks for the reviews. I'll take a look at the title when I get a moment! |
jasmussen
force-pushed
the
fix/url-scrollbar
branch
from
ecddfda to
feba3e0
Compare
|
Okay, I rebased, and moved the After:
Feel free to give this branch a spin, otherwise since I've addressed the feedback, I'll land it some time after the tests hopefully pass. As with all software, we can always come back to this. Nothing is ever so perfect that it can't be improved upon. |
|
Thank you all for fixing this 🥳 |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
* Fix wordbreak for URLs * Use break-all instead. * Remove overflow-wrap. * prefer the new css prop `overflow-wrap` * Only apply to URL. Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36961. URLs didn't wrap:
They do after this PR:
For what it's worth, I don't personally think it's that valuable to see the full URL like this, especially when it gets clipped in editing it after the fact:
But that's a not at all a strong opinion, so I've kept the behavior as is, given the CSS comment pointed to a particular issue.
How has this been tested?
Add a very long URL that does not include hyphens, and observe that it still gets broken up.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).