Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QueryControls README.md #37233

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Update QueryControls README.md #37233

merged 1 commit into from
Dec 9, 2021

Conversation

jhned
Copy link
Contributor

@jhned jhned commented Dec 8, 2021

Description

Add the prop definitions to the QueryControls component.

How has this been tested?

Tested by cross-referencing the QueryControls component index.js to determine how best to write the prop definitions.

Types of changes

Documentation

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] I've tested my changes with keyboard and screen readers.
  • [n/a] My code has proper inline documentation.
  • [X ] I've included developer documentation if appropriate.
  • [n/a] I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Add the prop definitions to the QueryControls component.
@jhned jhned requested a review from ajitbohra as a code owner December 8, 2021 17:35
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jhned! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Dec 8, 2021
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution to the docs.
I appreciate the effort to make the platform better 👍

};

const MyQueryControls = () => {
const [ query, setQuery ] = useState( QUERY_DEFAULTS );
const { orderBy, order, category, categories, numberOfItems } = query;
const { category, categories, maxItems, minItems, numberOfItems, order, orderBy } = query;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for alphabetizing the list! So much better! 💯

@mkaz mkaz merged commit 2bad33c into WordPress:trunk Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Congratulations on your first merged pull request, @jhned! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 9, 2021
@jhned jhned deleted the patch-1 branch December 13, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants