Navigation: Fix vertical alignment of page list in modal. #37321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
Size Change: +6 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
georgeh
approved these changes
Dec 13, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #36991. That PR fixed the contents of the modal overlay menu to always be top aligned, despite what might have been inherited.
But the page list can still be aligned wrongly. Here's a justified-right menu, which should justify the contents of the modal right, but still keep it towards the top:
Here's the page list showing the bug, being bottom justified:
Here's the bug, fixed:
How has this been tested?
Insert a navigation menu that's set to always be responsive, have a page list inside, justify it right. The contents of the modal should still be top aligned.
Checklist:
*.native.jsfiles for terms that need renaming or removal).