Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move block patterns compatibility code to lib/compat folder #37451

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Move block patterns compatibility code to lib/compat folder #37451

merged 1 commit into from
Dec 16, 2021

Conversation

ntsekouras
Copy link
Contributor

Code quality work similar to #37141

@ntsekouras ntsekouras added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 16, 2021
@ntsekouras ntsekouras self-assigned this Dec 16, 2021
@ntsekouras ntsekouras added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 16, 2021
Mamaduka
Mamaduka approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected in my tests. Patterns are loaded correctly, and I don't see any errors on the PHP side.

@ntsekouras ntsekouras merged commit f2614c7 into trunk Dec 16, 2021
@ntsekouras ntsekouras deleted the move/block-patterns-code-to-compat-layer branch December 16, 2021 14:45
@github-actions github-actions bot added this to the Gutenberg 12.3 milestone Dec 16, 2021
@tellthemachines tellthemachines removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 21, 2021
tellthemachines pushed a commit that referenced this pull request Dec 21, 2021
@ntsekouras @tellthemachines
Move block patterns compatibility code to lib/compat folder (#37451)
9d02c36
@ntsekouras ntsekouras mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@iandunn iandunn Awaiting requested review from iandunn

@ryelle ryelle Awaiting requested review from ryelle

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees

@ntsekouras ntsekouras

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 12.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ntsekouras @Mamaduka @tellthemachines