Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block: add core/paragraph in transforms object #38295

Conversation

amustaque97
Copy link
Member

Fixes: #38288

Description

Add core/paragraph in order to support block transformation

Testing Instructions

  1. Checkout to the PR and build the project
  2. Create/edit a post
  3. Add paragraph block and write some text
  4. click on transform
  5. select transform to code
  6. Validate existing paragraph block will be converted to code block

Screenshots

image

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@amustaque97 amustaque97 added [Block] Paragraph Affects the Paragraph Block [Block] Code Affects the Code Block [Type] Enhancement A suggestion for improvement. labels Jan 28, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Thanks, @amustaque97.

@Mamaduka Mamaduka merged commit 65b092a into WordPress:trunk Feb 1, 2022
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 1, 2022
@paaljoachim
Copy link
Contributor

What a nice surprise! Thank you for tackling this @amustaque97 !
It is much appreciated!

@amustaque97 amustaque97 deleted the feature/transform-paragraph-block-code-block branch February 1, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Code Affects the Code Block [Block] Paragraph Affects the Paragraph Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform Paragraph block into Code block.
3 participants