Image Block: explicitly check for false from strpos() #38505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from the conversation in #35975 (review)
This PR explicitly checks for a return value of
false
fromstrpos()
just in case the check returns0
, which would also be falsey and satisfy the if-statement's condition.If
data-id
were at the leading position in the string though, we'd have other problems :)Props to @mcsf for catching it.
Testing Instructions
Insert a gallery and a single image into a post. Publish the page and head over to your site.
Make sure that the published gallery images include the
data-id
attribute on the<img />
tags. The single image will not have thedata-id
attribute.Screenshots
Types of changes
Code qual.
Checklist:
*.native.js
files for terms that need renaming or removal).