Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate theme documentation #38800

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Remove duplicate theme documentation #38800

merged 1 commit into from
Mar 23, 2022

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Feb 15, 2022 •
edited
Loading

Description

Remove theme documentation that covers stable features that have been added to WordPress 5.9,
because these features are documented in the theme developer handbook.

Closes #38795 #31999

Types of changes

Documentation update

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@carolinan carolinan added the [Type] Developer Documentation Documentation for developers label Feb 15, 2022
aristath
aristath approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Should finally fix the duplicate docs issue

@carolinan carolinan merged commit 7d7682e into trunk Mar 23, 2022
@carolinan carolinan deleted the docs/remove-duplicate-theme-docs branch March 23, 2022 05:15
@github-actions github-actions bot added this to the Gutenberg 12.9 milestone Mar 23, 2022
@t-hamano t-hamano mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mkaz mkaz Awaiting requested review from mkaz

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.9
Development

Successfully merging this pull request may close these issues.

Remove duplicate theme docs
2 participants
@carolinan @aristath