Block Editor: Hydrate block before duplication #38921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +74 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
closing this one out for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP part of #30276
Some types of blocks like Navigation and Template Parts, don't fully serialize their contents in innerBlocks. They instead use a reference like a
slugstring, orrefid which may point to other post entities.When copying or duplicating we do a shallow rather than a deep copy. Meaning that changes in one block will be reflected in another. This PR explores hydrating these types of blocks before duplication, so that we can have a deep copy.
I have a proof of concept in the branch for the Navigation block, but I still need to work through template parts. There appears to be a naming step that I need to work through.
I could use some early feedback on how much block-editor should know about the internal workings of a particular library block. It could be that we need to provide a sort of copy or hydration mechanism for each block to implement instead.
CleanShot.2022-02-18.at.14.27.33.mp4