Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Fix hyperlink in block Metadata page #38941

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

sanzeeb3
Copy link
Contributor

@sanzeeb3 sanzeeb3 commented Feb 21, 2022

Description

Fixes #38940.

Capital letters make incorrect links.

In the documentation: https://developer.wordpress.org/block-editor/reference-guides/block-api/block-metadata/

Script #Script
Type: WPDefinedAsset (learn more)
Optional
Localized: No
Property: script

Clicking n learn more leads to nowhere because of capital letters in hyperlinks.

Testing Instructions

  1. Go to https://developer.wordpress.org/block-editor/reference-guides/block-api/block-metadata/
  2. Click on learn more as stated above.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 21, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sanzeeb3! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sanzeeb3!

Can you please update the remain similar references? They are five in total as I could see.

@ntsekouras ntsekouras added the [Type] Developer Documentation Documentation for developers label Feb 21, 2022
@ntsekouras ntsekouras changed the title Fix hyperlink [Documentation]: Fix hyperlink in block Metadata page Feb 21, 2022
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @sanzeeb3 🎉

@ntsekouras ntsekouras merged commit a91eee0 into WordPress:trunk Feb 22, 2022
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 22, 2022
@gziolo
Copy link
Member

gziolo commented Feb 22, 2022

Thank you for the improvement 👍🏻

@sanzeeb3 sanzeeb3 deleted the patch-1 branch February 23, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect URL in block Metadata documentation
3 participants