Update: Keep additional classes during a block transform. #38964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +99 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/keep-classes-during-block-transforms
branch
from
351f13f to
4495785
Compare
ntsekouras
approved these changes
Feb 22, 2022
| } | ||
|
|
||
| // If the condition verifies we are probably in the presence of a wrapping transform | ||
| // e.g: nesting paragraphs in a group or columns and in that case the styles should not be transformed. |
There was a problem hiding this comment.
Just adjust the comments that refer to styles, to mention the classes 😄
jorgefilipecosta
force-pushed
the
update/keep-classes-during-block-transforms
branch
from
4495785 to
637dc54
Compare
jorgefilipecosta
deleted the
update/keep-classes-during-block-transforms
branch
ZebulanStanphill
added
the
[Feature] Block Transforms
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows feedback given on comment #30815 (comment) and adds functionality to keep the additional class names during a block transform.
Testing Instructions
I added one paragraph block with a classname converted it to a heading and verified the classname was kept. I converted the heading back to a paragraph and verified the classname persisted.
I added two headings and a classname to each of the headings converted the headings using the multiselection option to a paragraph and verified the classnames were kept.
I added one paragraph block with a classname converted it to a group and verified the classname was not added to the group.
I added two paragraphs each containing a classname converted both paragraphs to a list and verified the classname was not kept.