Fix file block validation error by not outputting aria-describedby if there's no description #39083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
changed the title
|
Size Change: +16 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #39057
There's a logic flaw in the file block. It always adds an
aria-describedbyid to the download button when saving. The problem is that the matching id for this is the filename<a>element, which isn't saved when there's no text. When reloading the saved content, the block tries to source this id from the filename element, but it can't because that element doesn't exist. That causes a validation error.It doesn't make sense for the block to have an
aria-describedbythat references nothing, so the best solution seems to be to only addaria-describedbywhen there's a filename.Testing Instructions
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).