[core-data] Do not suppress errors in the getEntityRecord and getEntityRecords resolvers #39317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
changed the title
|
Size Change: +6 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Mar 10, 2022
Is there any way to not reject but communicate the error and then in a future version reject? |
|
adamziel
changed the title
|
To be honest I wonder if we should just go ahead and make the change (remove the try/catch). Some breaking changes feel more like bug fixes (like here :) ) |
|
@youknowriad ha, that's how this PR started! :-) Then I chatted to @draganescu about deprecating it instead, but given that more people have the same reaction as I initially did, I reverted the deprecation notice and went for removing the catch clause entirely instead. Also ccing @gziolo for reviews. |
|
End to end tests seems to be failing in the same way as on my other PRs, must be a global issue – let's not block reviewing on that. |
adamziel
changed the title
I don't have enough context here to be helpful. |
draganescu
approved these changes
Mar 12, 2022
youknowriad
approved these changes
Mar 14, 2022
gziolo
deleted the
update/throw-resolution-errors-in-core-data-resolvers
branch
37 tasks
adamziel
added
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now that the resolution errors are handled by our redux store, core-data resolvers may stop silencing them.
Note this is a breaking change in that the promises returned by resolveSelect( coreStore ).getEntityRecord/Records will now be rejected on failure whereas previously they were resolved without any possible way of learning that an error occurred.
Testing Instructions
Check if all the checks below this PR are green.
cc @kevin940726 @jsnajdr @youknowriad @gziolo @Mamaduka @draganescu