Packages: Ensure that @wordpress/preferences gets published to npm
#39390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
8 tasks
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
|
Thanks for that, sorry for leaving it as private. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for #38873 that added a new
@wordpress/preferencespackage but marked it as private.Raised on WordPress Slack (requires registration at https://make.wordpress.org/chat):
https://wordpress.slack.com/archives/C02QB2JS7/p1647001592635239
Why?
Having
@wordpress/preferencesas a private package prevented it from publishing to npm. Other packages depend on it so it isn't possible to download them anymore.How?
This PR marks
@wordpress/preferencesas public.I also included a changelog entry for
@wordpress/scriptsto include when publishing packages to npm.