Template Mode: Try fix flaky tests #39711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Automated Testing
|
Usually, GitHub Action passed these tests on the second run. However, when running locally, I got mixed results even after using the correct store to disable Welcome Guide, so there might be another reason for flakiness. |
|
Size Change: +602 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
@talldan, it's looks like a few preferences like |
talldan
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Template mode tests were failing because the Welcome Guide wasn't correctly disabled.
Fixes following error:
Why?
Tests need a welcome guide to being disabled.
How?
Use the correct store to disable Welcome Guide.
Testing Instructions
E2E Tests should be passing