List View: Only show ellipsis on first selected item or when focused #40174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Size Change: +138 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Apr 8, 2022
jasmussen
approved these changes
Apr 8, 2022
|
Thanks for the speedy reviews, folks! 🙇 |
andrewserong
deleted the
update/list-view-to-only-show-ellipsis-on-first-selected-item-unless-hovered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40066
What?
In the List View component, only show the icon for the ellipsis / settings menu on the first selected item in a multi selection, to reduce clutter in the interface. So that the settings are still accessible for any other selected item, the icon is revealed when an item is hovered or focused.
This PR also tweaks the border radii so that only the first and last selected items have rounded borders, so that the selection looks a bit more like a single selected unit.
Why?
As reported in #40066, when many items are selected in the List View, the settings icon appearing on every row makes the interface look a little cluttered.
How?
ListViewBlockcomponent, check if the current block is the first or last selected.is-first-selectedandis-last-selectedso that the border radii is set correctly on only the first and last selected blocks. If there is only one selected block, it will receive both of these class names, so the border radii should still be correct.Testing Instructions
Screenshots or screencast
Screen grab: