Corrected the order in the code tabs #40569
Conversation
In step 1 there are two code tabs, JSX and Plain. I changed the order of the first one so they match. This makes it easier to compare the differences, making it a simple but nice change.
tomjdv
requested review from
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @tomjdv! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
| "title": "Example: Basic (ESNext)", | ||
| "icon": "universal-access-alt", | ||
| "name": "gutenberg-examples/example-01-basic-esnext", |
There was a problem hiding this comment.
Thank you for the PR. I agree with you that it will make easier for the users to understand. Though not sure if this change is required or not. Let's wait for the others to comment.
There was a problem hiding this comment.
Thanks for the response @amustaque97. I'm not sure what you mean by "required", though. It's a (small) improvement, and there are no risks whatsoever, so I don't see any reason to not publish it.
There was a problem hiding this comment.
Thanks for the response @amustaque97. I'm not sure what you mean by "required", though. It's a (small) improvement, and there are no risks whatsoever, so I don't see any reason to not publish it.
I agree there is no risk but there could be a chance someone suggest to improve a few other things. or other possibility is that there might be some high priority PR needs to be reviewed/merged.
|
Congratulations on your first merged pull request, @tomjdv! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
What?
Corrected the order in the code tabs.
Why?
In step 1 there are two code tabs, JSX and Plain. The order didn't match. I changed the order of the first one so now they align perfectly. This makes it easier to compare the differences, making it a simple but nice change.
How?
Corrected the order in the code tabs.
Testing Instructions