Provide translators comment for Font size and Letter Case #40879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some languages ie. Polish it's possible to provide similar translations for both strings, this translators comment will help to prompt translators to ensure uniqueness between the two.
tomasztunik
force-pushed
the
fix/38329-font-size-letter-case-translation-context
branch
from
9a53cc0 to
b719ee9
Compare
tomasztunik
added
the
Internationalization (i18n)
tomasztunik
added
the
[Type] Bug
tomasztunik
deleted the
fix/38329-font-size-letter-case-translation-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Provide translators' comment for "Font size" and "Letter Case" in the typography panel to make it less likely for these two strings to be translated the same way.
Fixes #38329
Why?
In some languages - ie. Polish - it's possible to provide similar translations for both strings, this translator's comment will help to prompt translators to ensure uniqueness between the two.
Apart from possibly this making the UI confusing with two settings behind the same name it also caused the UI to not render correctly as we sometimes rely on labels as unique identifiers ie. like with the Tools Panel.
How?
Update block-editor
TypographyPanelto provide translators' comments to reduce the chance of this issue reappearing.