Fix the position of the inbetween inserter #40919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
youknowriad
added
the
[Feature] Inserter
This was referenced May 9, 2022
|
Size Change: +9 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
creativecoder
approved these changes
May 9, 2022
There was a problem hiding this comment.
Confirming that this fixes the issue described by Automattic/wp-calypso#63279
Thanks @youknowriad !
|
Thanks @youknowriad! |
|
My query block just stopped filtering properly by category. Any chance it's related to this fix? |
|
@Diachrony no, not possible. maybe @ntsekouras would know about any recent Query block changes, otherwise feel free to create an issue with all the details. |
|
@youknowriad Thanks. I found the issue. #41067 Looks like it might just be a 13.2 thing and wordpress.com happened to adopt the update last night so I thought it might be the 13.2.1 release given the timing. |
That sounds right -- WordPress.com updated from 13.1 to 13.2.1 to include this inserter fix before release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #40738
What?
After #40441 there was a subtle change in the in-between inserter popover: the height of the popover content changed from "0" to the actual real height (the available space) (because It was absolute positioned). I think the new behavior is better but it also triggered the automatic direction flipping for the popover if there were no available space. This PR fixes it by forcing the "position" of the popover.
Testing Instructions
1- Insert some content in a new post
2- Insert a spacer with a vw based height
3- Insert some content after the spacer
4- The in-between inserter should always show in the right position (between blocks and not on top of blocks).