[Writing Flow]: Fix browser formatting with shortcuts on multiple selection #41207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +32 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
fix/browser-formatting-on-multiple-selection
branch
from
fd657e2 to
864169d
Compare
ntsekouras
force-pushed
the
fix/browser-formatting-on-multiple-selection
branch
from
864169d to
a3d3ed5
Compare
mcsf
approved these changes
May 24, 2022
| return; | ||
| } | ||
| // Prevent the browser to format something when we have multiselection. | ||
| if ( event?.inputType?.startsWith( 'format' ) ) { |
There was a problem hiding this comment.
event?.inputType?.
// ^Can event ever be falsy?
There was a problem hiding this comment.
Do we need to clarify where these format* input events come from? Or is this easy enough to understand?
There was a problem hiding this comment.
Can event ever be falsy?
I guess not :). I made some more tests and I don't think it's possible to get here without an event.
Do we need to clarify where these format* input events come from? Or is this easy enough to understand?
I think the Prevent the browser is enough.
ntsekouras
force-pushed
the
fix/browser-formatting-on-multiple-selection
branch
from
1927812 to
4f91031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #41164
Some common shortcuts for formatting like
cmd + b (bold), cmd + i(italic), etc...are implemented by browsers. In GB we handle such events in RichText for multiple reasons(example would be different markup applied per browser). With the current multiple selection implementation we make conditionally the content beingcontentEditablewhich in turn enabled the browsers to add markup with such shortcuts.At first this seemed to work well, but we keep all formatting internally in RichText, and that's why when you would select a single block afterwards, the formatting was 'gone'.
So, until we implement this(issue) we need to disable these formatting from browsers.
Testing Instructions
Before
before.mov
After
after.mov