ColorPicker: Strip hash from pasted hex values in ColorPicker #41223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Strips leading
#
character from hex values pasted into theColorPicker
's hex input field.Why?
The leading
#
on pasted values persists in the input field until the value is committed. This lead to confusion as to whether the color value was invalid or not.How?
Leveraged
InputControl
's__unstableStateReducer
to process pasted values, stripping any leading#
from the value.Testing Instructions
npm run test-unit packages/components/src/color-picker/test
Screenshots or screencast
Screen.Recording.2022-05-23.at.3.02.40.pm.mp4
Screen.Recording.2022-05-23.at.3.03.20.pm.mp4