Add transforms between Heading & Cover Image #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
approved these changes
Dec 21, 2017
| @@ -18,6 +17,10 @@ | |||
| text-align: center; | |||
| } | |||
|
|
|||
| &:not(.components-placeholder) h2 { | |||
There was a problem hiding this comment.
Minor: .components-placeholder is only used in the editor so I think this rule should not be added in style.scss. Maybe we can keep style.scss as it is and a rule in the editor that makes our h2 placeholder the color we want.
There was a problem hiding this comment.
Totally agree. Amended.
mcsf
force-pushed
the
add/heading-cover-image-transforms
branch
from
88ed3e8 to
b9d8f85
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4003
How Has This Been Tested?
Screenshots (jpeg or gifs if applicable):
Types of changes
Checklist: