[Block Editor]: Fix block variation registration when icon is an object and contains transform scope
#41457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
…bject` and contains `transform` scope
ntsekouras
force-pushed
the
fix/transform-block-variations-with-icon-object
branch
from
c9522bb to
c89bc01
Compare
ntsekouras
commented
May 31, 2022
packages/block-editor/src/components/block-variation-transforms/index.js
Outdated
Show resolved
Hide resolved
|
Size Change: +32 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 31, 2022
andrewserong
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Thanks for fixing this up @ntsekouras, the code change looks good to me, too!
I noticed that with the testing instructions, the added dashicon based icon button appears to be rendered slightly lower than the other buttons for some reason:
Not a blocker for landing this fix, but could be good for us to look into in a follow-up — I couldn't quite work out why it's sitting lower, but the difference appears to be that the other block icons render an inline svg and dashicons uses a span with a ::before rule. 🤔
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
…bject` and contains `transform` scope (#41457) * [Block Editor]: Fix block variation registration when `icon` is an `object` and contains `transform` scope * show colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #41453
Introduced in: #40036
Why?
Currently if we register a block variation with an
objecticonand includetransforminscope, there is a check to show onlyiconsin the block variations transform control in inspector controls, which breaks the editor. We don't take into account that theiconcan be anobjectso I updated the code to useBlockIconwhich does and seems a better choice either way for this use case.Testing Instructions
consoleand add the below snippetGroupblock and observe that in inspector controls show the variation's icon.Snippet to add in console
Before
before.mov
After
after.mov