Adds featured image toggle to media replace flow #41476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +175 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
I find it confusing that when the featured image option is selected the other options aren't visible.
There's a few reasons that I find it confusing:
|
I agree. What if we have the selected state active but keep the other "Open Media Library" and "Upload" present. And when you upload an image, or select from the media library, the This way, if the featured image is being used, you don't have to turn it off to use the other controls. But adding a separate image would make the Cover block use the new image instead of the featured image.
|
|
@scruffian Yea, I'll spin off a diff PR to explore a pressed state for menu items that is less confusing. To be fair, the mockups in #40156 are cool and nice I only tried this PR with the simplest approach to get a hands on experience of moving that to the dropdown. @richtabor yep, I'll see that option in this PR 👏🏻 |
|
In 746e041 the options are preserved. I think this can be added like this, and I can follow up with a better UI for the dropdown's "selected" elements. |
Base automatically changed from
add/cover-block-featured-image-placeholder
to
trunk
June 8, 2022 14:44
scruffian
force-pushed
the
add/featured-image-toggle-media-replace-flow
branch
from
746e041 to
7307ec0
Compare
scruffian
approved these changes
Jun 9, 2022
I was thinking the same, although there are a few new controls that the post featured image block has:
|
|
Fantastic work, @draganescu! Have you considered passing the new P.S. Happy to follow up with a PR. |
|
@Mamaduka I think this is a great observation and the reason the On the other hand the props list just grew with 2 items ... |
That's 1/3 of the core blocks that use the
It's the reason I thought composition might be a better option here. |
annezazu
added
the
Backport to WP Minor Release
gziolo
removed
the
Backport to WP Minor Release
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Advances #40156. Adds featured image toggle to media replace flow, uses
cover block to showcase.
Why?
Having the media option in the same place seems more intuitive. The
toolbar block control seemed to bother many users and a lot of UX
feedback consistently asked for this toggle to be in the media replace
how.
Also, as other media blocks would like to have access to featured image
it's good to expose it through one common interface element.
How?
Adds a toggle to the dropdown. If the block that uses
MediaReplaceFlowprovides a featured image handler the toggle shows up. When featured
image is toggled on the other options are not visible.
Testing Instructions
the other media options are not visible
Screenshots or screencast
featured--image-replace-flow.mp4