-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@wordpress/editor
: Add estimated time to read to table of contents in editor
#41611
Merged
+66
−2
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3818424
Add TimeToRead component
opr 8def320
Add TimeToRead to the table of contents panel
opr 8c2372b
Adjust average reading rate
opr 17dae93
Use createInterpolateElement to show the minutes to read
opr d171a84
Re-order information in toc panel
opr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useSelect } from '@wordpress/data'; | ||
import { _x, _n, __, sprintf } from '@wordpress/i18n'; | ||
import { count as wordCount } from '@wordpress/wordcount'; | ||
import { createInterpolateElement } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { store as editorStore } from '../../store'; | ||
|
||
/** | ||
* Average reading rate - based on average taken from | ||
* https://irisreading.com/average-reading-speed-in-various-languages/ | ||
* (Characters/minute used for Chinese rather than words). | ||
* | ||
* @type {number} A rough estimate of the average reading rate across multiple languages. | ||
*/ | ||
const AVERAGE_READING_RATE = 189; | ||
|
||
export default function TimeToRead() { | ||
const content = useSelect( | ||
( select ) => select( editorStore ).getEditedPostAttribute( 'content' ), | ||
[] | ||
); | ||
|
||
/* | ||
* translators: If your word count is based on single characters (e.g. East Asian characters), | ||
* enter 'characters_excluding_spaces' or 'characters_including_spaces'. Otherwise, enter 'words'. | ||
* Do not translate into your own language. | ||
*/ | ||
const wordCountType = _x( 'words', 'Word count type. Do not translate!' ); | ||
const minutesToRead = Math.round( | ||
wordCount( content, wordCountType ) / AVERAGE_READING_RATE | ||
); | ||
const minutesToReadString = | ||
minutesToRead === 0 | ||
? createInterpolateElement( __( '<span>< 1</span> minute' ), { | ||
span: <span className="table-of-contents__number" />, | ||
} ) | ||
: createInterpolateElement( | ||
sprintf( | ||
/* translators: %s is the number of minutes the post will take to read. */ | ||
_n( | ||
'<span>%d</span> minute', | ||
'<span>%d</span> minutes', | ||
minutesToRead | ||
), | ||
minutesToRead | ||
), | ||
{ | ||
span: <span className="table-of-contents__number" />, | ||
} | ||
); | ||
|
||
return <span className="time-to-read">{ minutesToReadString }</span>; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a special case for minutes to read less than 1 (or 0.5)? In that case, we could display:
Less than a minute
. Otherwise, we might see0 minutes
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gziolo I went with
< 1 minute
because without there being a number there it looks kind of weird.Compared to: