-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Block: More careful prompts to continue when minimum system requirements are not met #42254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quirements are not met
t-hamano
added
[Type] Enhancement
A suggestion for improvement.
[Tool] Create Block
/packages/create-block
labels
Jul 8, 2022
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank your for the follow-up PR 👍🏻
bph
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Tool] Create Block
/packages/create-block
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on: #42151
What?
As noted in this comment, we decided to display a more carefully message when system requirements are not met in Create Block.
But I forgot to commit that change after presenting the screen capture.
Sorry about that, but please check this PR to see that I have added it.
Screenshots or screencast