Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme.json: Fix schema for button elements #42431

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Theme.json: Fix schema for button elements #42431

merged 1 commit into from
Jul 20, 2022

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jul 14, 2022 •
edited
Loading

Follow up on: #42133

What?

This PR fixes the schema of styles.elements.button in theme.json.

Why?

elements properties can be nested forever because stylesElementsPropertiesComplete is defined as the schema of styles.elements.button

8ab7a0bd6d76dc99b042e0146d5f35fe.mp4

How?

Changed stylesElementsPropertiesComplete to stylesPropertiesComplete.

Testing Instructions

theme json

@t-hamano t-hamano added [Block] Buttons Affects the Buttons Block Developer Experience Ideas about improving block and theme developer experience labels Jul 14, 2022
@t-hamano t-hamano requested a review from ajlende as a code owner July 14, 2022 13:16
@carolinan carolinan merged commit 6133a21 into trunk Jul 20, 2022
@carolinan carolinan deleted the fix/schema-theme-elements-button branch July 20, 2022 10:05
@github-actions github-actions bot added this to the Gutenberg 13.8 milestone Jul 20, 2022
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Aug 4, 2022
@bph bph mentioned this pull request Oct 3, 2022
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ajlende ajlende Awaiting requested review from ajlende

Assignees
No one assigned
Labels
[Block] Buttons Affects the Buttons Block Developer Experience Ideas about improving block and theme developer experience Needs Dev Note Requires a developer note for a major WordPress release cycle
Projects
None yet
Milestone
Gutenberg 13.8
Development

Successfully merging this pull request may close these issues.
3 participants
@t-hamano @carolinan @bph