Style engine: update return PHP doc comment and other nitpicks #42453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename $style_rules to $css_declarations Change self to static for future classes that may extend this one
andrewserong
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some small changes that have been bugging me this afternoon.
So this PR:
declarationsto return value docsself::tostatic::for future classes that may extend this oneWhy?
Did I really need to create this PR? Not really.
Would I have slept tonight if I hadn't? HELL NO! 🔥
How?
Bashing at my keyboard.
Testing Instructions
If the tests pass, things are great.