Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Include has-visible-labels on edit component #42791

Merged

Conversation

dougwollison
Copy link
Contributor

What?

Adds the has-visible-labels class on the edit component if showLabels is checked.

Why?

Styling that relies on this class on the frontend is not reflected in the editor otherwise.

@dougwollison dougwollison requested a review from ajitbohra as a code owner July 28, 2022 23:53
@Soean Soean added the [Block] Social Affects the Social Block - used to display Social Media accounts label Jul 29, 2022
@Soean Soean changed the title Include has-visible-labels on edit component Social: Include has-visible-labels on edit component Jul 29, 2022
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I restarted the tests.

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Jul 31, 2022
@Mamaduka Mamaduka merged commit 5bfc80b into WordPress:trunk Jul 31, 2022
@github-actions github-actions bot added this to the Gutenberg 13.9 milestone Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants