Border Support: Fix disabling of border style control #43109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Good catch @aaronrobertshaw!
✅ Confirmed that on trunk the Border style controls are displayed even though opted-out
✅ Confirmed that this PR correctly hides the style controls when opted-out, in both the post editor and in global styles
✅ Confirmed that style controls are available when opted-in
✅ Saving and editing borders and border styles functions correctly in the post editor and global styles
LGTM! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the prop used to toggle the border style control within the border block support's
BorderBoxControl.Why?
This bug prevents disabling of the border style control by theme or block authors.
How?
Changes incorrect
showStyleprop toenableStyleTesting Instructions
Screenshots or screencast