Update fast-average-color #44175
Merged
Update fast-average-color #44175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Code Quality
|
Size Change: +441 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update fast-average-color to the latest version.
Why?
The new version reports errors instead of hiding them as a property in the callback (the Promise will reject). Updating to this version helped me figure out why
FastAverageColorwasn't working in #44174.How?
Updating fast-average-color from 4.0.3 to 9.1.1 had some breaking changes:
Fortunately, the updated version can be configured to behave like the old version:
process.env.NODE_ENV === 'production').defaultColorback to white so existing blocks don't change.Unfortunately, the library doesn't actually reject the promise when there is a CORS error—it resolves with the
defaultColorand logs errors unless thesilentoption is set, so those configuration options are the only way to maintain backwards compatibility.There may be an opportunity to address the CORS issue directly, but I've left that for another PR for another day.
Testing Instructions
Make sure the cover block is-dark/is-light heuristics are working by using different images with the overlay color opacity set to anything less than or equal to 50.
If running in a development environment the errors shown above should be logged.