[Block Library - Query Loop]: Suggest active variation patterns #44197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +1.25 kB (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Sep 16, 2022
oandregal
reviewed
Sep 16, 2022
|
Tested the setup and replace flows and works as advertised (loads the specific pattern if the theme has declared any and fallbacks to the query ones if the theme didn't declare one). |
|
This is great!
Should we be merging the patterns from the variation and the Query defaults instead of replacing? Though I guess it's better like this given a general purpose query pattern can be extended to cover your block type by registering your block type explicitly in its |
mtias
reviewed
Sep 16, 2022
mtias
added
the
[Feature] Patterns
gigitux
approved these changes
Sep 16, 2022
ockham
added
the
Backport to WP 6.7 Beta/RC
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
* [Block Library - Query Loop]: Suggest active variation patterns * optimization when no active variation exists * minor tweak * comment clarification
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 8edb659 |
ockham
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
With this PR it's possible to create Query Loop patterns for a specific block variation in the set up and replace flows.
The block determines if there is an active variation of the block and if there are available specific patterns for this variation. If there are, these patterns are going to be the only ones suggested to the user in setup and replace flow, without including the default ones for Query Loop. If there are no such patterns, the default ones for Query Loop are going to be suggested.
In order for a pattern to be 'connected' with a Query Loop variation, you should add to the pattern's
blockTypesproperty the name of your variation prefixed with the Query Loop name(excore/query/$variation_name). This is the same convention we are also following for Template Parts, which also have similar flows for setup/replace.Testing Instructions
Products ListblockProducts Listblock the suggested patterns should be the default for Query LoopScreenshots or screencast
Screen.Recording.2022-09-15.at.5.31.23.PM.mov